Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodes: InstancedPointsNodeMaterial - don't rebuild every frame #29222

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

aardgoose
Copy link
Contributor

Rebuilding the shader code every frame isn't recommended.

Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
462 kB (111.4 kB) 462 kB (111.4 kB) +0 B

@aardgoose aardgoose changed the title Nodes: InstancedPointsNodeMaterial Nodes: InstancedPointsNodeMaterial - don't rebuild every frame Aug 23, 2024
@RenaudRohlinger RenaudRohlinger added this to the r168 milestone Aug 24, 2024
@RenaudRohlinger RenaudRohlinger merged commit d189313 into mrdoob:dev Aug 24, 2024
12 checks passed
@aardgoose aardgoose deleted the ip branch August 26, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants