Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGPURenderer: Add bloom emissive/selective examples #28913

Merged
merged 9 commits into from
Jul 18, 2024

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jul 18, 2024

Related issue: #28903

Description

Live example

image

@sunag sunag added this to the r167 milestone Jul 18, 2024
@sunag sunag changed the title WebGPURenderer: Bloom emissive WebGPURenderer: Add bloom emissive example Jul 18, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 18, 2024

Good call to make a separate example for this!

A common feature request is selective bloom meaning only certain objects of the scene should be affected by the bloom effect. The setup of the existing example is a bit complicated though: webgl_postprocessing_unreal_bloom_selective

When I understand the new example correctly, emissive could also be used for selective bloom by defining an emissive color for each object that should be affected by bloom, right? Do you think we could port webgl_postprocessing_unreal_bloom_selective to WebGPURenderer by using this approach?

@sunag sunag changed the title WebGPURenderer: Add bloom emissive example WebGPURenderer: Add bloom emissive/selective example Jul 18, 2024
@sunag sunag changed the title WebGPURenderer: Add bloom emissive/selective example WebGPURenderer: Add bloom emissive/selective examples Jul 18, 2024
@sunag
Copy link
Collaborator Author

sunag commented Jul 18, 2024

It's possible control the intensity of bloom per object now.

Live example

image

@sunag
Copy link
Collaborator Author

sunag commented Jul 18, 2024

When I understand the new example correctly, emissive could also be used for selective bloom by defining an emissive color for each object that should be affected by bloom, right? Do you think we could port webgl_postprocessing_unreal_bloom_selective to WebGPURenderer by using this approach?

webgpu_mrt_mask is the approach base that I used for these two examples

@sunag sunag marked this pull request as ready for review July 18, 2024 22:19
@sunag sunag merged commit 460efde into mrdoob:dev Jul 18, 2024
11 checks passed
@sunag sunag deleted the dev-bloom-emissive branch July 18, 2024 22:36
@sunag sunag restored the dev-bloom-emissive branch July 18, 2024 22:36
@sunag sunag deleted the dev-bloom-emissive branch July 18, 2024 22:36
@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 19, 2024

Great solution! Much better than what we had before with WebGLRenderer 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants