Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E: WebGPU flags and macos-lastest #28783

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

E2E: WebGPU flags and macos-lastest #28783

wants to merge 10 commits into from

Conversation

mrdoob
Copy link
Owner

@mrdoob mrdoob commented Jul 2, 2024

👀

@mrdoob
Copy link
Owner Author

mrdoob commented Jul 2, 2024

Hmm, maybe WebGPU is working with this config? 🤔

@sunag Maybe we need a forceWebGPU parameter in WebGPURenderer() to be sure?

@sunag
Copy link
Collaborator

sunag commented Jul 2, 2024

Hmm, maybe WebGPU is working with this config?

It seems to work 🎉🎉🎉

image

This settings broken WebGL backend tests?

@mrdoob
Copy link
Owner Author

mrdoob commented Jul 2, 2024

This settings broken WebGL backend tests?

Looks like yah. I'm checking with @greggman to see if he has any ideas.

@@ -246,6 +241,7 @@ async function main() {
/* Launch browser */

const flags = [ '--hide-scrollbars', '--enable-gpu' ];
flags.push( '--enable-unsafe-webgpu', '--enable-webgpu-developer-features', '--use-angle=swiftshader', '--user-agent=puppeteer' );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try --use-angle=metal. Also, you probably don't need --user-agent=puppeteer. I had that in some rule so that some other code could tell if it was running in puppeteer or another browser.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, just FYI, I added some code to both twgl's tests and webgpu-utils's tests to log the browser info (from navigator.userAgentData) and the GPU info (from WEBGL_debug_renderer_info in WebGL and from adapter.info, adapter.requestAdapterInfo in WebGPU. It let me see that it was using WebGL with OpenGL instead of Metal on Windows. It also let me see what version of chrome puppeteer is using. You might want to do the same.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants