GLTFExporter: export rendertarget #28653
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
marwie
commented
Jun 13, 2024
| const cube = new THREE.Mesh( new THREE.BoxGeometry( 200, 200, 200 ), new THREE.MeshBasicMaterial( { color: 0xffffff, map: renderTexture.texture } ) ); | ||
| scene1.add( cube ); | ||
|
|
||
| }, 10) |
There was a problem hiding this comment.
This is just some hacky test code of course.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const cube = new THREE.Mesh( new THREE.BoxGeometry( 200, 200, 200 ), new THREE.MeshBasicMaterial( { color: 0xffffff, map: renderTexture.texture } ) ); | ||
| scene1.add( cube ); | ||
|
|
||
| }, 10) |
Check notice
Code scanning / CodeQL
Semicolon insertion Note
Mugen87
reviewed
Jun 15, 2024
|
|
||
| const width = map.image.width; | ||
| const height = map.image.height; | ||
| const buffer = new Uint8Array(width * height * 4); |
There was a problem hiding this comment.
Always assuming RGBA8 is not safe, see #28652 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #28652
Description
Currently exporting a scene that has a WebGLRendertarget Texture on any object breaks export altogether.
This PR adds a reference to the original WebGLRenderTarget to the underlying textures - not sure if this coupling is something you'd consider keeping.
Perhaps the same could be done by a writer plugin - but I'm not sure how how to 1) either get a reference to the WebGLRenderTarget to be able to readback the pixels or 2) if there's a different preferred solution (e.g. blitting the render target to a new texture like with compressed textures)
This contribution is funded by Needle