Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: convert to ES6 class #25599

Merged
merged 4 commits into from
Mar 7, 2023
Merged

Conversation

marcofugaro
Copy link
Contributor

@marcofugaro marcofugaro commented Mar 2, 2023

Related issue: Fixes #25595

Description
In order to prevent the same issue in the future, I think it's safer to convert the WebGLRenderer to ES6 class as well.

This way the physicallyCorrectLights can be a getter/setter of the class, which doesn't break tree-shaking.

@mrdoob mrdoob added this to the r151 milestone Mar 2, 2023
@mrdoob
Copy link
Owner

mrdoob commented Mar 6, 2023

Should we merge this after #25615 so we can test the new CI feature?

@marcofugaro
Copy link
Contributor Author

Hmm the action worked but there has been a problem in the CI, fixed it in #25625

@marcofugaro marcofugaro changed the title WebGLRenderer: convert to ES6 class WebGLRenderer: convert to ES6 class Mar 6, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

📦 Bundle size

Filesize Gzipped Diff from dev
616.6 kB 154.3 kB -0.04%

🌳 Bundle size after tree-shaking

Includes a renderer, camera, and empty scene.

Filesize Gzipped Diff from dev
409 kB 100.6 kB -0.06%

@LeviPesin
Copy link
Contributor

-0.04%

Maybe the action should also report an absolute value by how the size changed? I.e. not in percents but in KB.

@mrdoob
Copy link
Owner

mrdoob commented Mar 9, 2023

Maybe the action should also report an absolute value by how the size changed? I.e. not in percents but in KB.

That'd be nice yeah.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build Size grows 5x with ThreeJs 0.150.0
4 participants