Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OrbitControls: Use onPointerUp() for pointercancel events. #25540

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Feb 21, 2023

Fixed #25505.

Description

The pointercancel event is now handled like pointerup. This will ensure correct internal state if pointercancel is fired.

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Feb 21, 2023

@Mugen87 Mugen87 changed the title OrbitContorls: Use onPointerUp() for pointercancel events. OrbitContorls: Use onPointerUp() for pointercancel events. Feb 21, 2023
@Mugen87 Mugen87 added this to the r150 milestone Feb 22, 2023
@mrdoob mrdoob modified the milestones: r150, r151 Feb 23, 2023
@Mugen87 Mugen87 changed the title OrbitContorls: Use onPointerUp() for pointercancel events. OrbitControls: Use onPointerUp() for pointercancel events. Feb 23, 2023
@Mugen87 Mugen87 merged commit 05f6df7 into mrdoob:dev Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OrbitControls stays in incorrect state after pointercancel event
3 participants