Docs: Improved PMREMGenerator page. #23514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
reviewed
Feb 17, 2022
| resolution to smoothly interpolate diffuse lighting while limiting sampling computation. | ||
| resolution to smoothly interpolate diffuse lighting while limiting sampling computation.<br/><br/> | ||
|
|
||
| Note: The minimum [page:MeshStandardMaterial]'s roughness depends on the size of the provided texture: |
There was a problem hiding this comment.
You might also note this is a slightly conservative bound. If your render has small dimensions or the shiny parts have a lot of curvature, you may still be able to get away with a smaller texture size.
There was a problem hiding this comment.
Added that additional info verbatim.
WestLangley
reviewed
Feb 17, 2022
| @@ -15,7 +15,36 @@ <h1>[name]</h1> | |||
| CubeUV format that allows us to perform custom interpolation so that we can support nonlinear formats such as RGBE. | |||
There was a problem hiding this comment.
Does the RGBE comment still apply?
There was a problem hiding this comment.
No, good catch, since it's all float now.
There was a problem hiding this comment.
I think this page and the comments in the source code may be outdated. Can you please have a look? 😇
|
Merging for now... |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
* Docs: Improved PMREMGenerator page. * Update PMREMGenerator.html * Update PMREMGenerator.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23428 (comment)
Description
@elalish @WestLangley How does the explanation sound to you?