-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed broken pointerevent handling when pointerType = "pen" #20336
Conversation
You have to modify the files in |
I understand this is an established workflow and this has been discussed already, but It feels quite backwards to keep doing that. Generated modules have a clear notice:
As we already use |
@arodic its a transition not an instant switch |
@DefinitelyMaybe what has changed on May 2020 (r117) regarding the transition? |
We have to do this only for three more month. After that, |
Thanks! |
Yes it should. |
Oh, it seems there is a misunderstanding. I thought we've only agreed to remove the files at the end of the year and don't add new files to |
I've been seeing that quite like a lot of people include I was referring to the question on whether we should be modifying I think @donmccurdy had a PR that did that but I have not been able to study it and test it. |
My PR would have generated files like It sounds like you're saying we should be "modifying |
That was #16920 but I think I'm in agreement with @donmccurdy and @Mugen87 -- at this point we should just wait out the 3 months if we're truly going to get rid of the |
Recent transition to pointerevents broke all examples when using a pen such as Wacom stylus for example.