Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few ES6 class conversions #18912

Closed
wants to merge 6 commits into from
Closed

A few ES6 class conversions #18912

wants to merge 6 commits into from

Conversation

DefinitelyMaybe
Copy link
Contributor

Unsure as to whether the following would be the preference of converting
ArrayCamera.prototype = Object.assign( Object.create( PerspectiveCamera.prototype ), { ... isArrayCamera: true
to
constructor() { ... Object.defineProperty( this, 'isArrayCamera', { value: true } ); }

a simple this.isArrayCamera = true does the above simply enough but should we worry about someone then calling ___.isArrayCamera = false?

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 17, 2020

#18863 (comment)

@DefinitelyMaybe
Copy link
Contributor Author

Ah! thank you again. This PR had changed a couple of var's to let's. I've undone that change. Progress might be slow but yes, one thing at a time is best.

@DefinitelyMaybe
Copy link
Contributor Author

oops. missed up the merge commit. Will close request and make a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants