GLTFLoader: Implement support for KHR_mesh_quantization #17923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements support for KHR_mesh_quantization by simply recognizing the extension as supported. It seems that the extension works otherwise after various quantization fixes submitted previously (with the most recent fix including correct morph target handling for deltas that are quantized with a different data type vs baseline attribute).
donmccurdy
approved these changes
Nov 14, 2019
mrdoob
changed the title
|
Thanks! |
|
I'm a bit confused. What is this extension? The link you provided in the code is not valid: |
|
@Usnul the extension will appear at that URL after KhronosGroup/glTF#1673 is merged. For now the details are in that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements support for KHR_mesh_quantization by simply
recognizing the extension as supported. It seems that the extension
works otherwise after various quantization fixes submitted previously
(with the most recent fix including correct morph target handling for
deltas that are quantized with a different data type vs baseline
attribute).
Test scene: BrainStem.glb.zip