-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSM: Added module and TS file for ConvexObjectBreaker #16698
Conversation
The previous merges produces a conflict. Do you mind resolving^^? |
I've not made a resolve before. I know how to edit the conflicted file but no idea of the necessary git commands. Github instructs me to do this:
But I'm not sure of the final Edit: I've got defined |
For a simple conflict like this you should be able to do it here. Just click the 'resolve conflicts' button, edit the file until it looks right (remove all the >>>> lines) and then mark it resolved. |
Yes, but if I knew how to do it in the console I could resolve more complex conflicts in the future, that's why I asked... Edit: Also, I've got to add more commits, so if I resolve in this web, I must know how to integrate the changes with git in my computer. |
It seems I did the merge and the resolving right, in the console. Thank you :-) |
Thanks! |
Module generated by
modularize.js
I've tested that the example works OK with modules, in another directory.
I've not tested the TS file (and it is manually created)
Edit:
To be merged after #16697
Related #16688