Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSM: Added module and TS file for ConvexObjectBreaker #16698

Merged
merged 3 commits into from
Jun 6, 2019
Merged

JSM: Added module and TS file for ConvexObjectBreaker #16698

merged 3 commits into from
Jun 6, 2019

Conversation

yomboprime
Copy link
Collaborator

@yomboprime yomboprime commented Jun 5, 2019

Module generated by modularize.js

I've tested that the example works OK with modules, in another directory.

I've not tested the TS file (and it is manually created)

Edit:
To be merged after #16697
Related #16688

@yomboprime yomboprime requested a review from Mugen87 June 5, 2019 23:49
@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 6, 2019

The previous merges produces a conflict. Do you mind resolving^^?

@yomboprime
Copy link
Collaborator Author

yomboprime commented Jun 6, 2019

I've not made a resolve before. I know how to edit the conflicted file but no idea of the necessary git commands.

Github instructs me to do this:

Step 1: From your project repository, check out a new branch and test the changes.

git checkout -b yomboprime-jsm_convexbreaker dev
git pull https://github.com/yomboprime/three.js.git jsm_convexbreaker

Step 2: Merge the changes and update on GitHub.

git checkout dev
git merge --no-ff yomboprime-jsm_convexbreaker
git push origin dev

But I'm not sure of the final git push origin dev, because I think it should be pushed on my jsm_convexbreaker branch.
Could you help me?

Edit: I've got defined upstream

@looeee
Copy link
Collaborator

looeee commented Jun 6, 2019

For a simple conflict like this you should be able to do it here. Just click the 'resolve conflicts' button, edit the file until it looks right (remove all the >>>> lines) and then mark it resolved.

@yomboprime
Copy link
Collaborator Author

yomboprime commented Jun 6, 2019

For a simple conflict like this you should be able to do it here. Just click the 'resolve conflicts' button, edit the file until it looks right (remove all the >>>> lines) and then mark it resolved.

Yes, but if I knew how to do it in the console I could resolve more complex conflicts in the future, that's why I asked...

Edit: Also, I've got to add more commits, so if I resolve in this web, I must know how to integrate the changes with git in my computer.

@yomboprime
Copy link
Collaborator Author

It seems I did the merge and the resolving right, in the console. Thank you :-)

@Mugen87 Mugen87 merged commit f420e67 into mrdoob:dev Jun 6, 2019
@yomboprime yomboprime deleted the jsm_convexbreaker branch June 6, 2019 16:41
@mrdoob mrdoob added this to the r106 milestone Jun 6, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 6, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants