Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderTargetCube: added fromEquirectangularTexture() method #16671

Merged
merged 1 commit into from
Jun 4, 2019

Conversation

WestLangley
Copy link
Collaborator

As proposed in #15331 (comment).

Usage:

var options = {
	generateMipmaps: true,
	minFilter: THREE.LinearMipMapLinearFilter,
	magFilter: THREE.LinearFilter
};

var cubeMap = new THREE.WebGLRenderTargetCube( 512, 512, options ).fromEquirectangularTexture( renderer, texture );

I will provide docs in a later PR if we agree this is the API we want.

I will also port the examples.

@WestLangley WestLangley added this to the r106 milestone Jun 4, 2019
@mrdoob mrdoob merged commit b687988 into mrdoob:dev Jun 4, 2019
@mrdoob
Copy link
Owner

mrdoob commented Jun 4, 2019

Thanks!

@WestLangley WestLangley deleted the dev_from_equirect branch June 4, 2019 22:52
@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 6, 2019

I think we can update now the documentation and the TS file.

BTW: Some users were irritated of the fact that the project provides several ways to convert an equirectangular texture into the cube map format. It's good if we promote WebGLRenderTargetCube.fromEquirectangularTexture() as the way to go and remove EquirectangularToCubeGenerator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants