Add check for Object3D.add and Object3D.remove #16115
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fast path when the result of
Object3D.add
orObject3D.remove
should be a no-op.Sometimes it is convenient to use
add
andremove
methods in a context where they will be called each frame, potentially on the same parent/child objects:This change prevents unnecessary work in the
add
andremove
methods when sequentially adding/removing the same object to to/from the same parent, including preventing the "added" and "removed" events from being dispatched repeatedly.