Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Texture.updateMatrix() method #13888

Merged
merged 1 commit into from
Apr 18, 2018
Merged

Add Texture.updateMatrix() method #13888

merged 1 commit into from
Apr 18, 2018

Conversation

WestLangley
Copy link
Collaborator

Quite handy.

@mrdoob mrdoob added this to the r92 milestone Apr 18, 2018
@mrdoob mrdoob merged commit 9b7e901 into mrdoob:dev Apr 18, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 18, 2018

Thanks!

@WestLangley WestLangley deleted the dev-texture_update_matrix branch April 18, 2018 19:40
@WestLangley
Copy link
Collaborator Author

/ping @donmccurdy Can GLTFLoader be updated to use this method? I am not sure how that was overlooked...

@donmccurdy donmccurdy mentioned this pull request Jun 9, 2018
Merged
@donmccurdy
Copy link
Collaborator

Good call, thanks! #14262

@pailhead
Copy link
Contributor

I am not sure how that was overlooked...

In the most constructive way, i think this is also related to "staging" examples. It's possible when you were looking at this:
https://github.com/pailhead/three.js/blob/aa72250835b82f7dde2e8375775a4b039cb719c6/examples/webgl_materials_extended_multiple_uvs.html#L353-L363
#14174 (comment)

that this example code triggered something subconscious, which lead to this fix 🙂 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r92
Development

Successfully merging this pull request may close these issues.
5 participants
@WestLangley @mrdoob @donmccurdy @pailhead @Mugen87