-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional makeEmpty in THREE.Box3 #10474
Conversation
Instead, why not add the method Box3.expandByObject( object ) and rewrite |
@WestLangley added! |
@@ -92,8 +94,6 @@ Box3.prototype = { | |||
|
|||
setFromPoints: function ( points ) { | |||
|
|||
this.makeEmpty(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you remove makeEmpty()
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sry my distraction... I will add.
I'm not 100% sure about the consistency of this change. |
@Mugen87 We have |
I see... |
Thanks! |
Need to update the docs for the new |
Not a documented method yet, but have been included in the latest build (r84) of the library. See mrdoob/three.js#10474 for more info.
Not a documented method yet, but have been included in the latest build (r84) of the library. See mrdoob/three.js#10474 for more info.
Hi.
This solve problems with to collect parallel objects(no relationship) in THREE.Box3.
Otherwise would have to create a
Box3
for each object or add all in an singleObject3D