CylinderGeometry: Don't add degenerate triangles (#29460)

* CylinderGeometry: Don't add degenerate triangles * Change comparison
mrdoob · Sep 21, 2024 · ae67bfd · ae67bfd
1 parent ffe877f
commit ae67bfd
Showing 1 changed file with 11 additions and 4 deletions.
diff --git a/src/geometries/CylinderGeometry.js b/src/geometries/CylinderGeometry.js
@@ -133,12 +133,19 @@ class CylinderGeometry extends BufferGeometry {
 
 					// faces
 
-					indices.push( a, b, d );
-					indices.push( b, c, d );
+					if ( radiusTop > 0 ) {
 
-					// update group counter
+						indices.push( a, b, d );
+						groupCount += 3;
 
-					groupCount += 6;
+					}
+
+					if ( radiusBottom > 0 ) {
+
+						indices.push( b, c, d );
+						groupCount += 3;
+
+					}
 
 				}