Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Fix: Correction to Exercise 8 Title and Removal of Redundant Operation" #1148

Merged

Conversation

Crucifixion-Fxl
Copy link
Contributor

Subject: Correction for Exercise Title in Exercise 8

Hi Daniel,

I noticed a small error in the title of Exercise 8 in your notebook and have already made a correction. Please feel free to review the update.

Best regards,
Adam

@Crucifixion-Fxl
Copy link
Contributor Author

I noticed a redundant unsqueeze(0) operation in the code. I've addressed the issue and corrected it. Please take a look at the updated version when convenient.

pred_dict["pred_prob"] = round(pred_prob.unsqueeze(0).max().cpu().item(), 4)

to

pred_dict["pred_prob"] = round(pred_prob.max().cpu().item(), 4)

@Crucifixion-Fxl Crucifixion-Fxl changed the title "fix: incorrect-08-exercise-title" "Fix: Correction to Exercise 8 Title and Removal of Redundant Operation" Dec 5, 2024
@mrdbourke
Copy link
Owner

Beautiful fixes, thank you very much :)

@mrdbourke mrdbourke merged commit c61af0c into mrdbourke:main Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants