-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix closure-compiler's error "redirection limit reached" #618
Conversation
Since a few days, the js minification was complaining about a redirection limit in the closure-compiler call. This was generating an error each time I have tried to use this tool. After a bit of investigation I have found out that it was missing some parameters that are now mandatory. Plus, it now works in https only.
Fix closure-compiler's "redirection limit reached"
After a little more digging into the code I have found that setting a few more parameters in my call could solve the same problem:
Still, I think that setting the default url to https would be useful, since http seems to be deprecated. Also, having those parameters set as default in |
you should never create pull-request from your master branch. as anything you add to your master branch will be included to the pull-request. however. i can cherry-pick your first commit |
but forcing https on environments that lack https support (openssl module, required ssl certs), can create more damage than keeping http:// protocol. so such change not okay for minor patch version. as you're stating http:// still works. i'd keep it in. |
ran test locally. http:// url always redirects regardless of the passed parameters.
|
Since a few days, the js minification was complaining about a redirection limit in the closure-compiler call. This was generating an error each time I have tried to use this tool.
After a bit of investigation I have found out that it was missing some parameters that are now mandatory. Plus, it now works in https only.