Skip to content

Commit

Permalink
phy: lantiq: vrx200-pcie: fix error return code in ltq_vrx200_pcie_ph…
Browse files Browse the repository at this point in the history
…y_power_on()

Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: e52a632 ("phy: lantiq: vrx200-pcie: add a driver for the Lantiq VRX200 PCIe PHY")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
  • Loading branch information
Wei Yongjun authored and kishon committed Oct 31, 2019
1 parent 3817c79 commit 82b5d16
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion drivers/phy/lantiq/phy-lantiq-vrx200-pcie.c
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,8 @@ static int ltq_vrx200_pcie_phy_power_on(struct phy *phy)
goto err_disable_pdi_clk;

/* Check if we are in "startup ready" status */
if (ltq_vrx200_pcie_phy_wait_for_pll(phy) != 0)
ret = ltq_vrx200_pcie_phy_wait_for_pll(phy);
if (ret)
goto err_disable_phy_clk;

ltq_vrx200_pcie_phy_apply_workarounds(phy);
Expand Down

0 comments on commit 82b5d16

Please sign in to comment.