Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reqwest Showcase #1

Open
wants to merge 2 commits into
base: upstream-bevy-web-asset
Choose a base branch
from

Conversation

mnmaita
Copy link

@mnmaita mnmaita commented Nov 14, 2024

Some notes from my end:

  • I haven't fine tuned the dependencies. We might want to review that and disable default features, only turn on the ones we need, etc.
  • I would run this through someone that has experience with async rust since I just did something that makes the example work but I have no idea if this is an OK implementation (e.g. should the runtime be multithreaded always in this scenario or should it be feature gated? do we even need the tokio runtime for this, can it be made simpler? etc.).

Copy link

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@mnmaita
Copy link
Author

mnmaita commented Nov 14, 2024

@mrchantey here's the PR as promised! Let me know what do you think and please check my notes. Thanks!

@mrchantey
Copy link
Owner

thank you thats perfect 🙏 ill make sure to get some input from a bevy async wizard before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants