mrc-5446 Fix reset axes button #215
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Reset axes' button (the 'Home' icon button in the plotly mode bar) became broken when we introduced keeping x-axis consistent across graphs - this is because we added additional relayouts which specified both x and y ranges (retaining user selected y range if any), and these ranges were re-applied when "Reset axes" was clicked, rather than resetting x and y axes to full range, which I think is what user would be expecting. The only exception is if "Lock y axis" is selected in graph settings - in this case, x axis is reset but locked y range is still applied.
This was implemented by overriding default modebar button behaviour and replacing it with autorange relayout.
NB This branch is based on mrc-5443 and should be re-pointed to epic branch mrc-5490 when mrc-5443 is merged.