Adjust ChatLog MessageIndicator for consistency with the base game #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what happened? |
|
this seems like a good idea, unless you give a reason i'm going to implement this and credit you |
mrbuilder1961
added a commit
that referenced
this pull request
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a simple change to the
MessageIndicatorused by theChatLogclass, to improve consistency when identifying chat messages based on the indicator.In the base game, a translatable text object is passed as the 3rd parameter of the
MessageIndicatorconstructor, and a hard-coded string is passed as the 4th parameter.Currently, ChatPatches passes a translated string as the 4th parameter, preventing other mods from using that string to identify messages.
Modifying the
MessageIndicatorto be consistent with the base game will allow other mods to correctly identify messages added byChatLogwhen processing chat.