feat(form): actions (submit & base button) in form (#5) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe overall changes revolve around enhancing form functionality within a React application. This includes dynamic rendering of form fields and actions via a Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
package-lock.jsonis excluded by:!**/*.jsonpackage.jsonis excluded by:!**/*.json
Files selected for processing (13)
- apps/docs/src/app/app.tsx (2 hunks)
- packages/components/form/src/components/actions/base/actionBase.tsx (1 hunks)
- packages/components/form/src/components/actions/base/actionBase.types.ts (1 hunks)
- packages/components/form/src/components/actions/submit/submit.tsx (1 hunks)
- packages/components/form/src/components/actions/submit/submit.types.ts (1 hunks)
- packages/components/form/src/components/builder/builder.types.ts (1 hunks)
- packages/components/form/src/components/fields/text/text.tsx (2 hunks)
- packages/components/form/src/components/fields/text/text.types.ts (1 hunks)
- packages/components/form/src/types/public.types.ts (1 hunks)
- packages/components/form/src/utils/selector/selector.tsx (1 hunks)
- packages/components/form/src/utils/selector/selector.types.ts (1 hunks)
- packages/core/src/lib/components/builder/builder.tsx (2 hunks)
- packages/core/src/lib/utils/selector/selector.tsx (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/components/form/src/components/fields/text/text.tsx
- packages/components/form/src/components/fields/text/text.types.ts
Additional comments: 14
packages/components/form/src/components/builder/builder.types.ts (2)
- 1-1: The import statement has been updated to include
FormTypesinstead ofFIELD_TYPE. This change aligns with the PR's objective to refactor and rename for clarity.- 4-4: The
fieldTypeinBuilderPropshas been updated fromFIELD_TYPEtoFormTypes. This change is consistent with the renaming effort and ensures type safety with the newFormTypes.packages/components/form/src/utils/selector/selector.types.ts (2)
- 1-1: The import statement has been updated to use
FormTypesinstead ofFIELD_TYPE. This change is part of the refactoring effort to improve naming conventions and clarity.- 4-4: The
fieldTypeinSelectorPropshas been updated fromFIELD_TYPEtoFormTypes. This update is consistent with the renaming effort and enhances type safety with the newFormTypes.packages/components/form/src/components/actions/base/actionBase.types.ts (1)
- 4-6: The introduction of
ActionBasePropstype is well-defined, extendingLoadingButtonPropsfrom Material-UI and including achildrenprop of typeReactNode. This type definition is clear and aligns with React component prop patterns.packages/components/form/src/components/actions/submit/submit.types.ts (1)
- 4-4: The introduction of
ActionSubmitFieldPropstype, extendingActionBasePropsand includingFormId, is well-defined. This type definition ensures that submit actions have access to form identification, which is crucial for form management.packages/components/form/src/components/actions/base/actionBase.tsx (1)
- 5-6: The
ActionBasecomponent is correctly implemented, utilizingLoadingButtonfrom Material-UI and spreadingactionBasePropsto pass all necessary props. This implementation ensures that the component is flexible and can handle various loading states as defined by the props.packages/components/form/src/types/public.types.ts (2)
- 10-10: The introduction of
FormTypeswith values 'field-text' and "action-submit" is a significant improvement for type safety and clarity in form field management. This change supports the dynamic rendering capabilities introduced in the PR.- 12-12: Updating
FieldPropsto acceptActionSubmitFieldPropsin addition toTextPropsis a logical step to accommodate the new action components. This update ensures that the types are correctly aligned with the components they represent.packages/core/src/lib/components/builder/builder.tsx (2)
- 8-8: Converting
GROUP_TYPEfrom an enum to a type with a single value'form'simplifies the type structure and aligns with the current use case. This change is a good example of simplifying code without losing clarity or functionality.- 17-17: Updating the
typeproperty inIFormTextBuilderPropsfromFIELD_TYPEtoFormTypesis consistent with the renaming effort and enhances type safety with the newFormTypes. This change ensures that the builder component can handle the new form field types introduced in the PR.packages/core/src/lib/utils/selector/selector.tsx (1)
- 4-4: Updating the import to use
FormTypesinstead ofFIELD_TYPEand adjusting the corresponding usage in theSelectorPropsinterface is consistent with the renaming effort and enhances type safety. This change ensures that the selector component can dynamically load components based on the new form field types.packages/components/form/src/utils/selector/selector.tsx (1)
- 10-30: The update to the
Selectorcomponent to support dynamic loading of components based on the field type (field-textandaction-submit) is a significant enhancement. This change allows for more flexible and scalable form configurations. The use oflazyfor component loading andSuspensefor fallback handling is correctly implemented, ensuring a smooth user experience during component loading.apps/docs/src/app/app.tsx (1)
- 79-79: The usage of the
Buildercomponent with thegroupListprop for dynamic rendering is correctly implemented.
| }, | ||
| }, | ||
| { | ||
| id: '4', |
There was a problem hiding this comment.
Duplicate id value for the entry with id: '4'. Each entry in the groupList should have a unique id to avoid potential rendering issues or unintended behavior.
Comment on lines
+7
to
+22
| const ActionSubmit: FC<ActionSubmitFieldProps> = ({ | ||
| formId, | ||
| children, | ||
| ...submitFieldProps | ||
| }) => { | ||
| const forms = useForms((state) => state.forms); | ||
| const { handleSubmit } = forms[formId]; | ||
| const onSubmit = (values: FieldValues) => { | ||
| console.log(values); | ||
| }; | ||
|
|
||
| return ( | ||
| <Button {...submitFieldProps} onClick={handleSubmit(onSubmit)}> | ||
| {children} | ||
| </Button> | ||
| ); |
There was a problem hiding this comment.
The ActionSubmit component is well-implemented, utilizing the Button component from Material-UI and the useForms hook for form management. The use of handleSubmit from the form's state to wrap the onSubmit function ensures that form submission is handled correctly. However, consider handling the submission result or errors, as logging values to the console might not be sufficient for production use.
Consider enhancing the onSubmit function to handle submission results or errors, providing feedback to the user or further processing the form data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5
📝 Description
actions (submit & base button) in form
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Summary by CodeRabbit
groupListdata structure.ActionBaseandActionSubmitcomponents for enhanced form submission handling.field-textandaction-submit.Selectorcomponent for different field types.