Replace html/template with text/template #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The the html/template package escapes certain special characters such as
`"`. If the messages received from Alertmanager contain these special
characters they will show up HTML-encoded in the chat message.
summary: Server "foo" is down
instead of:
summary: Server "foo" is down
This patch relaces html/template with text/template because there's no
need for special HTML escape rules to generate a notification message.
Resolves #7
Signed-off-by: David Wagner <david.wagner@pix4d.com>
|
Thanks @wagdav |
|
@mr-karan Thanks for merging it so fast! Would you please make a patch release with this fix, so we could update our production system? Thank you! |
|
@wagdav Sure!
|
Thank you! I just deployed this 😎 We have also a cluster where we use the raw binary from Github Releases. There, the latest version is v0.1.5. Are you planning to release v1.1.0 there as well? Thanks again. |
|
It's done. https://github.com/mr-karan/calert/releases/tag/v1.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The the html/template package escapes certain special characters such as
". If the messages received from Alertmanager contain these specialcharacters they will show up HTML-encoded in the chat message.
instead of:
This patch relaces html/template with text/template because there's no
need for special HTML escape rules to generate a notification message.
Resolves #7
Signed-off-by: David Wagner david.wagner@pix4d.com