Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): release calert helm charts #50

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Aug 24, 2022

Closes #48
Closes #50

Before merging this, you'll have to

@aslafy-z aslafy-z marked this pull request as draft August 24, 2022 14:23
@mr-karan
Copy link
Owner

mr-karan commented Sep 5, 2022

Hi @aslafy-z Thanks for this. Let me know when it's ready to be reviewed!

@aslafy-z aslafy-z marked this pull request as ready for review December 6, 2022 12:53
@aslafy-z aslafy-z changed the title chore: release calert helm charts chore(ci): release calert helm charts Dec 6, 2022
@aslafy-z
Copy link
Contributor Author

aslafy-z commented Dec 6, 2022

@mr-karan This looks good to me. What do you think about syncing calert versions and calert chart versions?

@mr-karan
Copy link
Owner

Might be related (?) #56

@mr-karan
Copy link
Owner

@aslafy-z I missed this, sorry! A bit unclear, do you mean the helm chart version and calert version? I guess we can keep them same?

@granescb
Copy link

@mr-karan Sorry, will be progress here? We really wanna use this chart on our pipeline

@mr-karan
Copy link
Owner

Feel free to contribute, I don't really have any experience with helm.

@aslafy-z
Copy link
Contributor Author

#56 is related, yes. This pr will allow the use of this repository GitHub pages as a helm repository. The current implementation maps the git release tag to the helm version. @granescb can review to the impl so we can go forward?

@aslafy-z
Copy link
Contributor Author

Up @mr-karan. Did you find some time to review this pr?

@mr-karan
Copy link
Owner

@aslafy-z Sorry for late response. Yes, LGTM. We can use the git tag release version for Helm charts. I'm merging this.

@mr-karan mr-karan merged commit 52af2f4 into mr-karan:main Apr 27, 2023
@joaogbcravo
Copy link

Hey!

I'm getting a 404 error here:

helm repo add calert https://mr-karan.github.io/calert/charts
helm repo update
Error: looks like "https://mr-karan.github.io/calert/charts" is not a valid chart repository or cannot be reached: failed to fetch https://mr-karan.github.io/calert/charts/index.yaml : 404 Not Found

@aslafy-z enumerated some requirements on the first post. Is that missing?

@aslafy-z
Copy link
Contributor Author

It is indeed @joaogbcravo
@mr-karan can you please enable GH pages as explained in op?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish the chart to a helm registry / ArtifactHub
4 participants