Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logger: debug to pino #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

logger: debug to pino #129

wants to merge 1 commit into from

Conversation

YoDaMa
Copy link

@YoDaMa YoDaMa commented Mar 2, 2022

@mcollina would this be considered a feature change?

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a global logger is a bad idea and it will lead quickly to a feature creep. Instead, let's make it a parameter and store inside the parser. You can use https://www.npmjs.com/package/abstract-logging as a default so there is no performance overhead (no need to add pino as a dependency).

@givenvessel givenvessel linked an issue May 18, 2023 that may be closed by this pull request
@robertsLando robertsLando removed a link to an issue Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants