fix: _storeProcessing staying true after outStore got emptied
#1492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Genoil Could you add a unit test for this please? I'm ok to merge it as soon as a test covers the fix |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
=======================================
Coverage 86.22% 86.22%
=======================================
Files 13 13
Lines 1314 1314
=======================================
Hits 1133 1133
Misses 181 181
☔ View full report in Codecov by Sentry. |
robertsLando
changed the title
_storeProcessing staying true after outStore got emptied
|
@gabrielfnogueira could you confirm this fixes your issue? |
yes, this does fixes my issue! |
robertsLando
added a commit
that referenced
this pull request
Jun 30, 2023
Co-authored-by: Jan Willem Penterman <janwillem@gingeros.ai> Co-authored-by: Daniel Lando <daniel.sorridi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure that new messages get published after a local store that accumulated some messages while the broker was offline, reconnects. In storeDeliver, this._storeProcessing got set to true before the check if there are actually stored packets left to send. So if there aren't any, this._storeProcessing will still be true on the next publish(), resulting in packets accumulating in this._storeProcessingQueue, but their invokes are never called, because Readable Event 'end' has already happened for the emptied Store and no new messages will be put into the Store as well.
Fixes #1116