Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD Sub Language Select #15176

Closed
6 tasks done
Raidfire-SDR opened this issue Oct 25, 2024 · 9 comments · Fixed by #15160 or #15182
Closed
6 tasks done

OSD Sub Language Select #15176

Raidfire-SDR opened this issue Oct 25, 2024 · 9 comments · Fixed by #15160 or #15182
Labels

Comments

@Raidfire-SDR
Copy link

mpv Information

No response

Other Information

- Windows version:11
- GPU model, driver and version:rx550
- Source of mpv:
- Introduced in version:

Reproduction Steps

Attempt to use osd to change sub language.

Expected Behavior

I update my mpv about once a week in the last update the default changed for the OSD sub language select, before clicking the icon with left mouse selected the next sub, right the previous, now it pops up a menu of all languages that is almost unreadable and I cannot switch off the subs now. how to return to original defaults, can someone provide the osd parameter to add to the input conf.

Actual Behavior

unreadable menu.

Log File

mpvoutput.txt

Sample Files

No response

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
@na-na-hi
Copy link
Contributor

na-na-hi commented Oct 25, 2024

Fixed by #15160. Copy restore-osc-bindings.conf to script-opts/osc.conf in the config directory to restore the previous behavior.

@Samillion
Copy link
Contributor

Samillion commented Oct 26, 2024

For reference, to turn off subtitles in the new select menu, click on the same (active) subtitle track.

Personal note:
I realize sudden change can be overwhelming, but I highly recommend giving the new select menu a chance. Full mouse control, scrollable, fuzzy match typing. It is excellent in handling track lists (and audio device select).

Tip

If the font size for the select menu is too small, you can add the following in your mpv.conf

# change font size for console and select
script-opts-append=console-font_size=25

@guidocella
Copy link
Contributor

You are right that's it's unusable with the default font size. Please vote to increase it in #15044

@Raidfire-SDR
Copy link
Author

Raidfire-SDR commented Oct 26, 2024

I'm colour blind, the choice of colours makes it impossible to read, it wasn't the font size (which i have manually tweaked anyway for thing like the console) it's the colours, if you want it to be accessible to all it's going to need to go monochrome, anything green or red is a big no for colour blind people unless you want to put an opaque background under the menu to increase contrast - which detracts from the original idea.

Having to get out a keyboard for fuzzy typing is a step backwards, and a con not a pro, having it on the mouse was perfect it didn't require another device, how about a separate button next to the original that opens the menu so we have the best of both worlds?

Edited my osc.conf as per 'restore-osc-bindings' to get the original behavior back, can be closed but suggest better testing before release next time, not all of us have 20/20 vision and perfect mobility, subs are a big thing for me i need them even for just 2 days it has been a real pain in the *** trying to use the lua menu.

@Raidfire-SDR
Copy link
Author

Raidfire-SDR commented Oct 26, 2024

current back to old behavior osc.conf (a note on the never flag for the eagle eyed - that's my default, i map mouse fwd and back buttons to always and never in my input conf)

visibility=never
deadzonesize=1
sub_track_mbtn_left_command=cycle sub
sub_track_mbtn_right_command=cycle sub down
title=${media-title}
title_mbtn_left_command=show-text "${!playlist-count==1:[${playlist-pos-1}/${playlist-count}] }${media-title}"
title_mbtn_right_command=show-text ${filename}

chapter_prev_mbtn_right_command=show-text ${chapter-list} 3000
chapter_next_mbtn_right_command=show-text ${chapter-list} 3000

audio_track_mbtn_left_command=cycle audio
audio_track_mbtn_right_command=cycle audio down

@guidocella
Copy link
Contributor

We're not UI designers, suggestions for different colors are welcome. The selected item color is just the color for selected tab completions that NRK suggested (it is yellow, not green or red). I don't think we'll use monochrome by default as that would make the UI worse for everyone who is not color blind.

You don't have to use a keyboard for fuzzy typing since mouse support was just added. Adding more buttons was already rejected due to the OSC being too cluttered: #5067 (comment) #8065 (comment)
Script-opts to customize the bindings have been added and you don't even have to use the menu by default since you can change tracks with the wheel.

Everyone is welcome to test PRs, we can't force more people to provide reviews if they don't give them (but apparently there was more interest in reviewing the tab width configuration lol).

@Raidfire-SDR
Copy link
Author

Raidfire-SDR commented Oct 26, 2024

MPV is great with one exception anywhere text creeps into the UI it becomes incredibly difficult to use the last thing i want is a shiny apple style UI but something functional with high contrast, I don't think it's the font size as much as the weight, the text is always too thin and wiry making it hard for people with limited vision, if the text was thicker it would be more functional for the moment it's way too light to be of any use to me, mine is fixed with conf edits, i'm talking more out of the box for novice users.

My wheel is already in use....

My limited vision setting which makes it readable yet uncluttered is --osd-font-size=60

@guidocella
Copy link
Contributor

Are you talking about the monospace font? Try --script-opt=console-font=sans-serif, that's what I use. The default is monospace just to align tab completions on a grid in the console. I thought of defaulting the console to a proportional font when called for selection if no font was specified, dunno if that's wanted.

Even if you rebind the wheel using the wheel on OSC buttons should still work.

@Raidfire-SDR
Copy link
Author

Raidfire-SDR commented Oct 26, 2024

Now there's your answer...
Sans serif as default makes the new lua menu both look nice and functional with font size 60! Still puttin my mouse buttons back tho ;)

guidocella added a commit to guidocella/mpv that referenced this issue Oct 26, 2024
In the select menu there are no completions to align in a grid, so the
better looking proportional font of --osd-font can be used by default.
It is also easier to read for the visually impaired.

The text width calculation is no longer performed if the console is only
opened through select, it is only performed the first time something is
completed. This avoids having to pass an argument to get_font() to make
it use the monospace font regardless of selectable_items.

Fixes mpv-player#15176.
guidocella added a commit to guidocella/mpv that referenced this issue Oct 28, 2024
In the select menu there are no completions to align in a grid, so the
better looking proportional font of --osd-font can be used by default.
It is also easier to read for the visually impaired.

The text width calculation is no longer performed if the console is only
opened through select, it is only performed the first time something is
completed. This avoids having to pass an argument to get_font() to make
it use the monospace font regardless of selectable_items.

Fixes mpv-player#15176.
kasper93 pushed a commit that referenced this issue Oct 28, 2024
In the select menu there are no completions to align in a grid, so the
better looking proportional font of --osd-font can be used by default.
It is also easier to read for the visually impaired.

The text width calculation is no longer performed if the console is only
opened through select, it is only performed the first time something is
completed. This avoids having to pass an argument to get_font() to make
it use the monospace font regardless of selectable_items.

Fixes #15176.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants