-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSD Sub Language Select #15176
Comments
Fixed by #15160. Copy |
For reference, to turn off subtitles in the new select menu, click on the same (active) subtitle track. Personal note: Tip If the font size for the select menu is too small, you can add the following in your # change font size for console and select
script-opts-append=console-font_size=25 |
You are right that's it's unusable with the default font size. Please vote to increase it in #15044 |
I'm colour blind, the choice of colours makes it impossible to read, it wasn't the font size (which i have manually tweaked anyway for thing like the console) it's the colours, if you want it to be accessible to all it's going to need to go monochrome, anything green or red is a big no for colour blind people unless you want to put an opaque background under the menu to increase contrast - which detracts from the original idea. Having to get out a keyboard for fuzzy typing is a step backwards, and a con not a pro, having it on the mouse was perfect it didn't require another device, how about a separate button next to the original that opens the menu so we have the best of both worlds? Edited my osc.conf as per 'restore-osc-bindings' to get the original behavior back, can be closed but suggest better testing before release next time, not all of us have 20/20 vision and perfect mobility, subs are a big thing for me i need them even for just 2 days it has been a real pain in the *** trying to use the lua menu. |
current back to old behavior osc.conf (a note on the never flag for the eagle eyed - that's my default, i map mouse fwd and back buttons to always and never in my input conf) visibility=never chapter_prev_mbtn_right_command=show-text ${chapter-list} 3000 audio_track_mbtn_left_command=cycle audio |
We're not UI designers, suggestions for different colors are welcome. The selected item color is just the color for selected tab completions that NRK suggested (it is yellow, not green or red). I don't think we'll use monochrome by default as that would make the UI worse for everyone who is not color blind. You don't have to use a keyboard for fuzzy typing since mouse support was just added. Adding more buttons was already rejected due to the OSC being too cluttered: #5067 (comment) #8065 (comment) Everyone is welcome to test PRs, we can't force more people to provide reviews if they don't give them (but apparently there was more interest in reviewing the tab width configuration lol). |
MPV is great with one exception anywhere text creeps into the UI it becomes incredibly difficult to use the last thing i want is a shiny apple style UI but something functional with high contrast, I don't think it's the font size as much as the weight, the text is always too thin and wiry making it hard for people with limited vision, if the text was thicker it would be more functional for the moment it's way too light to be of any use to me, mine is fixed with conf edits, i'm talking more out of the box for novice users. My wheel is already in use.... My limited vision setting which makes it readable yet uncluttered is --osd-font-size=60 |
Are you talking about the monospace font? Try Even if you rebind the wheel using the wheel on OSC buttons should still work. |
Now there's your answer... |
In the select menu there are no completions to align in a grid, so the better looking proportional font of --osd-font can be used by default. It is also easier to read for the visually impaired. The text width calculation is no longer performed if the console is only opened through select, it is only performed the first time something is completed. This avoids having to pass an argument to get_font() to make it use the monospace font regardless of selectable_items. Fixes mpv-player#15176.
In the select menu there are no completions to align in a grid, so the better looking proportional font of --osd-font can be used by default. It is also easier to read for the visually impaired. The text width calculation is no longer performed if the console is only opened through select, it is only performed the first time something is completed. This avoids having to pass an argument to get_font() to make it use the monospace font regardless of selectable_items. Fixes mpv-player#15176.
In the select menu there are no completions to align in a grid, so the better looking proportional font of --osd-font can be used by default. It is also easier to read for the visually impaired. The text width calculation is no longer performed if the console is only opened through select, it is only performed the first time something is completed. This avoids having to pass an argument to get_font() to make it use the monospace font regardless of selectable_items. Fixes #15176.
mpv Information
No response
Other Information
Reproduction Steps
Attempt to use osd to change sub language.
Expected Behavior
I update my mpv about once a week in the last update the default changed for the OSD sub language select, before clicking the icon with left mouse selected the next sub, right the previous, now it pops up a menu of all languages that is almost unreadable and I cannot switch off the subs now. how to return to original defaults, can someone provide the osd parameter to add to the input conf.
Actual Behavior
unreadable menu.
Log File
mpvoutput.txt
Sample Files
No response
I carefully read all instruction and confirm that I did the following:
--log-file=output.txt
.The text was updated successfully, but these errors were encountered: