Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFmpeg Channel Layout Changes Break Audio Output With video-sync=display-resample #13662

Closed
CounterPillow opened this issue Mar 7, 2024 · 3 comments · Fixed by #13665
Closed

FFmpeg Channel Layout Changes Break Audio Output With video-sync=display-resample #13662

CounterPillow opened this issue Mar 7, 2024 · 3 comments · Fixed by #13665
Labels
os:linux

Comments

@CounterPillow
Copy link
Contributor

Important Information

Provide following Information:

  • mpv version: mpv v0.37.0-514-g78447c4b91
  • Linux Distribution and Version: Arch btw, 6.7.8
  • Source of the mpv binary: mpv-build
  • Window Manager and version: kwin 6.0.1 (Wayland)
  • GPU model, driver and version: AMD Radeon Vega 10 Graphics, amdgpu, mesa 24.0.2

Reproduction steps

mpv --no-config --video-sync=display-resample https://www.youtube.com/watch?v=Wy6kZm-lC4g

Expected behavior

I hear the goose.

Actual behavior

No audio;

[ffmpeg] SWR: Input channel layout "" is invalid or unsupported.
[swresample] Cannot open Libavresample context.
[swresample] libswresample failed to initialize.
Cannot convert decoder/filter output to any format supported by the output.
Audio: no audio

in console.

Log file

https://overviewer.org/~pillow/up/4a35281ea6/penis.log
@CharlesMengCA
Copy link

Same error on window's build.

@Dudemanguy
Copy link
Member

This is because our usage of libswresample implicitly relied on the stuff ffmpeg just removed. The handling of it needs to be updated as well, namely the channel mappings.

@CharlesMengCA CharlesMengCA mentioned this issue Mar 8, 2024
Closed
@CounterPillow CounterPillow mentioned this issue Mar 8, 2024
Closed
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue Mar 8, 2024
@Dudemanguy
swresample: stop using deprecated {in,out}_channel_layout options
edcec18 
These options were deprecated with the addition of the channel layout
API about a couple of years ago*. Unfortunately, we never saw the
deprecation messages so it went unnoticed until they were completely
removed with the recent major version bump. Fix this by setting
in_chlayout and out_chlayout instead if we have AV_CHANNEL_LAYOUT.

Fixes mpv-player#13662.

*: FFmpeg/FFmpeg@8a5896e
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue Mar 8, 2024
@Dudemanguy
swresample: stop using deprecated {in,out}_channel_layout options
aded18a 
These options were deprecated with the addition of the channel layout
API about a couple of years ago*. Unfortunately, we never saw the
deprecation messages so it went unnoticed until they were completely
removed with the recent major version bump. Fix this by setting
in_chlayout and out_chlayout instead if we have AV_CHANNEL_LAYOUT.

Fixes mpv-player#13662.

*: FFmpeg/FFmpeg@8a5896e
@Dudemanguy Dudemanguy mentioned this issue Mar 8, 2024
Merged
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue Mar 8, 2024
@Dudemanguy
swresample: stop using deprecated {in,out}_channel_layout options
09d1584 
These options were deprecated with the addition of the channel layout
API about a couple of years ago*. Unfortunately, we never saw the
deprecation messages so it went unnoticed until they were completely
removed with the recent major version bump. Fix this by setting
in_chlayout and out_chlayout instead if we have AV_CHANNEL_LAYOUT.

Fixes mpv-player#13662.

*: FFmpeg/FFmpeg@8a5896e
Dudemanguy added a commit to Dudemanguy/mpv that referenced this issue Mar 8, 2024
@Dudemanguy
swresample: stop using deprecated {in,out}_channel_layout options
1a40b2f 
These options were deprecated with the addition of the channel layout
API about a couple of years ago*. Unfortunately, we never saw the
deprecation messages so it went unnoticed until they were completely
removed with the recent major version bump. Fix this by setting
in_chlayout and out_chlayout instead if we have AV_CHANNEL_LAYOUT.

Fixes mpv-player#13662.

*: FFmpeg/FFmpeg@8a5896e
@llyyr llyyr mentioned this issue Mar 8, 2024
Closed
Dudemanguy added a commit that referenced this issue Mar 8, 2024
@Dudemanguy
swresample: stop using deprecated {in,out}_channel_layout options
9ef614d 
These options were deprecated with the addition of the channel layout
API about a couple of years ago*. Unfortunately, we never saw the
deprecation messages so it went unnoticed until they were completely
removed with the recent major version bump. Fix this by setting
in_chlayout and out_chlayout instead if we have AV_CHANNEL_LAYOUT.

Fixes #13662.

*: FFmpeg/FFmpeg@8a5896e
@Hrxn
Copy link
Contributor

Hrxn commented Mar 9, 2024

Same error on window's build.

Yep..
FWIW, this is affected regardless of video-sync=display-resample on Win32 (cf. #13669)

Curious that these old channel layout options still worked on Linux without that option set, apparently.
Unless I've misunderstood this issue description here..

xrun1 pushed a commit to xrun1/mpv-svp-fix that referenced this issue Mar 12, 2024
@Dudemanguy @xrun1
swresample: stop using deprecated {in,out}_channel_layout options
f31eb9e 
These options were deprecated with the addition of the channel layout
API about a couple of years ago*. Unfortunately, we never saw the
deprecation messages so it went unnoticed until they were completely
removed with the recent major version bump. Fix this by setting
in_chlayout and out_chlayout instead if we have AV_CHANNEL_LAYOUT.

Fixes mpv-player#13662.

*: FFmpeg/FFmpeg@8a5896e
@jet082 jet082 mentioned this issue Jun 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
os:linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

swresample: stop using deprecated {in,out}_channel_layout options Dudemanguy/mpv
4 participants
@CounterPillow @Dudemanguy @Hrxn @CharlesMengCA