adding CI workflow for creating mpv binary and debian .deb package
#245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to be committed: new file: build_mpv_binary.yml
1- change the name of the workflow 2- change the branch name from main to master 3- add workflow_dispatch Changes to be committed: modified: build_mpv_binary.yml
Changes to be committed: modified: build_mpv_binary.yml
Changes to be committed: modified: build_mpv_binary.yml
Changes to be committed: modified: build_mpv_binary.yml
Changes to be committed: modified: build_mpv_binary.yml
Changes to be committed: modified: build_mpv_binary.yml
Changes to be committed: modified: build_mpv_binary.yml
Changes to be committed: renamed: build_mpv_binary.yml -> build_mpv_binary_and_deb_package.yml
Changes to be committed: modified: build_mpv_binary_and_deb_package.yml
sfan5
reviewed
Dec 18, 2024
|
Can I see the workflow in action somewhere? |
add `actions/checkout@v4` Co-authored-by: sfan5 <sfan5@live.de>
Changes to be committed: modified: build_mpv_binary_and_deb_package.yml
Co-authored-by: sfan5 <sfan5@live.de>
Changes to be committed: modified: build_mpv_binary_and_deb_package.yml
Changes to be committed: modified: build_mpv_binary_and_deb_package.yml
Changes to be committed: modified: build_mpv_binary_and_deb_package.yml
Changes to be committed: modified: build_mpv_binary_and_deb_package.yml
Changes to be committed: modified: build_mpv_binary_and_deb_package.yml
Changes to be committed: modified: build_mpv_binary_and_deb_package.yml
While building the package, by using equivs-build and debian/control file, I got the following error: ``` root@a625b7a1de7c:/mpv-build# equivs-build --full debian/control dpkg-buildpackage: info: source package mpv dpkg-buildpackage: info: source version 1.0 dpkg-buildpackage: info: source distribution unstable dpkg-buildpackage: info: source changed by Kevin Mitchell <kevmitch@gmail.com> dpkg-buildpackage: info: host architecture amd64 dpkg-source --before-build . debian/rules clean dh clean dh: error: Please specify the compatibility level in debian/compat or via Build-Depends: debhelper-compat (= X) make: *** [debian/rules:3: clean] Error 255 dpkg-buildpackage: error: debian/rules clean subprocess returned exit status 2 Error in the build process: exit status 2 ``` Based on the error message, I replaced debian/compat with debhelper-compate (= 12) in debian/control file. The existing compat file didn't help to build the package. [Reference](FooBarWidget/debian-packaging-for-the-modern-developer#8 (comment)) Changes to be committed: deleted: compat modified: control
|
In general, is it useful to build mpv twice, once separately and once as a package? Building the package already exercises the build scripts. We could drop the first two steps and if we want to run mpv --version we could just install the resulting .deb file. |
|
Can you please clarify the goal of this PR? Is it to test that a normal build works, and also the debian packging works? Or maybe only one of those? Is it supposed to produce an artifact which debian users can install? Something else? |
This reverts commit a664c8d. Changes to be committed: new file: debian/compat modified: debian/control
1. installation step is deleted during binary building
2. building `.deb` package is moved to `build_debian_package.yml`
3. `build_mpv_binary_and_deb_package.yml` is renamed to `build_debian_package.yml`
Changes to be committed:
renamed: build_mpv_binary_and_deb_package.yml -> build_debian_package.yml
new file: build_mpv_binary.yml
Changes to be committed: modified: build_debian_package.yml
ilkermeliksitki
force-pushed
the
master
branch
from
416f9e7 to
7c362f7
Compare
Changes to be committed: modified: build_debian_package.yml
Changes to be committed: modified: build_debian_package.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the workflow is only running on
ubuntu-24.04.During the creation of
.debpackage,libgnutls-devcouldn't be located and instead the other alternativelibgnutls28-devis used. I am not sure, but maybe we can delete it from the dependencies inside thedebian/controlfile.