Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: quantity_spec missing lint block end #663

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix: quantity_spec missing lint block end #663

merged 1 commit into from
Dec 31, 2024

Conversation

FrancoisCarouge
Copy link
Contributor

Add a missing lint bugprone-branch-clone block closing for function convertible_impl in file quantity_spec. The following error is solved in consumer code:

[...]/mp-units-src/src/core/include/mp-units/framework/quantity_spec.h:1073:6:
error: unmatched 'NOLINTBEGIN' comment without a subsequent 'NOLINTEND' comment [clang-tidy-nolint]
 1073 |   // NOLINTBEGIN(bugprone-branch-clone)
      |      ^

mpusz
mpusz approved these changes Dec 31, 2024
View reviewed changes
Copy link
Owner

@mpusz mpusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@mpusz mpusz merged commit db18eec into mpusz:master Dec 31, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpusz mpusz mpusz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrancoisCarouge @mpusz