added support for quantity_point math #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpusz
requested changes
May 10, 2024
src/core/include/mp-units/math.h
Outdated
| [[nodiscard]] constexpr bool isfinite(const quantity_point<R, PO, Rep>& a) noexcept | ||
| { | ||
| using std::isfinite; | ||
| return isfinite(a.quantity_ref_from(a.point_origin).numerical_value_ref_in(a.unit)); |
There was a problem hiding this comment.
Just reuse the other overload:
Suggested change
| return isfinite(a.quantity_ref_from(a.point_origin).numerical_value_ref_in(a.unit)); | |
| return isfinite(a.quantity_ref_from(a.point_origin)); |
Please do the same for the rest
src/core/include/mp-units/math.h
Outdated
| * @return bool: Whether the quantity point is finite or not. | ||
| */ | ||
| template<auto R, auto PO, typename Rep> | ||
| requires requires(Rep v) { isfinite(v); } || requires(Rep v) { std::isfinite(v); } |
There was a problem hiding this comment.
Maybe something like this?
Suggested change
| requires requires(Rep v) { isfinite(v); } || requires(Rep v) { std::isfinite(v); } | |
| requires requires(Quantity<R, Rep> q) { isfinite(q); } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small number of
math.hoperations are even well-specified for points in the affine space; I identifiedisfinite,isinfandisnanso far. We should eventually also supportmidpointandlerpeventually - both of them are currently missing for bare quantities either. Work for another PR.