[WIP] Bugfix: quantity_cast fails to compile when provided with a lvalue reference
#569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burnpanck
changed the title
quantity_cast fails to compile when provided with a lvalue referencequantity_cast fails to compile when provided with a lvalue reference
mpusz
requested changes
May 10, 2024
test/static/quantity_test.cpp
Outdated
| @@ -937,7 +937,11 @@ static_assert(is_of_type<quantity_cast<isq::distance>(1 * m), quantity<isq::dist | |||
| static_assert(is_of_type<quantity_cast<isq::distance>(isq::length(1 * m)), quantity<isq::distance[m], int>>); | |||
| static_assert(is_of_type<quantity_cast<kind_of<isq::length>>(isq::length(1 * m)), quantity<si::metre, int>>); | |||
| static_assert(is_of_type<quantity_cast<kind_of<isq::length>>(isq::distance(1 * m)), quantity<si::metre, int>>); | |||
|
|
|||
| // lvalue references in quantity_cast | |||
| inline constexpr quantity<isq::distance[m], int> to_distance(quantity<m, int> arg) | |||
There was a problem hiding this comment.
Also, I am not sure if we need a function here as it is not a test (although it has to be compiled correctly).
Maybe it would be better to define a quantity variable and pass it to a static_assert(). With this, you could check it the output type is exactly what you require as well.
mpusz
requested changes
May 10, 2024
Co-authored-by: Mateusz Pusz <mateusz.pusz@gmail.com>
|
This bug is really embarrassing. Thanks for finding and fixing it! |
|
BTW, CMake CI is broken now because the new Conan version is not compatible with the previous one. I have to fix it when I get some time. So do not be surprised by one failing GitHub action. |
|
Uh oh, I believe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.