Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fma to math.h #526

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Add fma to math.h #526

merged 3 commits into from
Dec 15, 2023

Conversation

NAThompson
Copy link
Contributor

@NAThompson NAThompson commented Dec 9, 2023 •
edited by JohelEGP
Loading

Resolves #525.

@NAThompson NAThompson force-pushed the add_fma branch 2 times, most recently from f19180a to 3411f7b Compare December 10, 2023 01:40
JohelEGP
JohelEGP requested changes Dec 10, 2023
View reviewed changes
src/utility/include/mp-units/math.h Outdated Show resolved Hide resolved
test/unit_test/static/math_test.cpp Outdated Show resolved Hide resolved
test/unit_test/runtime/math_test.cpp Outdated Show resolved Hide resolved
@NAThompson NAThompson force-pushed the add_fma branch 2 times, most recently from f240a22 to f9b09c7 Compare December 10, 2023 16:36
JohelEGP
JohelEGP requested changes Dec 10, 2023
View reviewed changes
src/utility/include/mp-units/math.h Outdated Show resolved Hide resolved
@NAThompson NAThompson force-pushed the add_fma branch 5 times, most recently from 169913f to 0e0b0ba Compare December 12, 2023 01:58
@NAThompson
Copy link
Contributor Author

@mpusz : Might wanna squash merge away those two merge commits.

JohelEGP
JohelEGP previously approved these changes Dec 12, 2023
View reviewed changes
src/utility/include/mp-units/math.h Outdated Show resolved Hide resolved
@NAThompson
Copy link
Contributor Author

@mpusz : Hopefully not an annoying ping, but I also want to add std::isfinite to the math.h and don't want to put you in merge hell!

mpusz
mpusz requested changes Dec 14, 2023
View reviewed changes
src/utility/include/mp-units/math.h Outdated Show resolved Hide resolved
src/utility/include/mp-units/math.h Outdated Show resolved Hide resolved
@NAThompson
Copy link
Contributor Author

@mpusz , @JohelEGP : My apologies for making you guys basically write my pull request; hopefully I've learned enough that the next one I can do myself.

Barring a build failure, all threads are resolved; merge at your convenience.

JohelEGP
JohelEGP previously approved these changes Dec 15, 2023
View reviewed changes
mpusz
mpusz requested changes Dec 15, 2023
View reviewed changes
src/utility/include/mp-units/math.h Outdated Show resolved Hide resolved
@NAThompson NAThompson force-pushed the add_fma branch 2 times, most recently from 41f17cf to 83a9ce5 Compare December 15, 2023 20:47
mpusz
mpusz approved these changes Dec 15, 2023
View reviewed changes
Copy link
Owner

@mpusz mpusz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mpusz mpusz merged commit 462b418 into mpusz:master Dec 15, 2023
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpusz mpusz mpusz approved these changes

@JohelEGP JohelEGP JohelEGP left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fatal error: no matching function for call to 'fma'
3 participants
@NAThompson @mpusz @JohelEGP