Allow whitespace in filenames

commands/webserver.go

@@ -225,7 +225,7 @@ func handleFilesUpload(w http.ResponseWriter, req *http.Request, bundleName stri
 func makeHandler(prefix string) (func(w http.ResponseWriter, req *http.Request)) {
 
   kBundleNameRe := "[a-zA-Z0-9_\\.\\-]{4,128}"
-  kFileNameRe := "[a-zA-Z0-9_\\.\\-]{4,128}"
+  kFileNameRe := "[a-zA-Z0-9_\\.\\-\\ ]{4,128}"
 
   rootRe := regexp.MustCompile("^" + prefix + "$")
   listBundleRe := regexp.MustCompile("^" + prefix + "bundle/(" + kBundleNameRe + ")/?$")

smoke-tests/test-web-send-receive-whitespace.sh

@@ -0,0 +1,36 @@
+#!/usr/bin/env bash
+
+set -e
+
+SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
+source ${SCRIPT_DIR}/util.sh
+
+# --
+
+BUNDLE_NAME="web-send-receive-test-whitespace-$((RANDOM))"
+F1=README.md
+F1_WITH_SPACES="READ ME.md"
+
+# Create a file with spaces in name
+cp ${NASEFA_ROOT}/${F1} "${TEMPDIR}/${F1_WITH_SPACES}"
+
+
+PORT=8081
+
+${NASEFA} web -bindAddr ":${PORT}" &
+WEB_PID=${!}
+log_debug "Started web, PID: ${WEB_PID}"
+
+${NASEFA} create -bundleName ${BUNDLE_NAME}
+log_debug "Bundle created: ${BUNDLE_NAME}"
+
+curl -s -F "file1=@${TEMPDIR}/${F1_WITH_SPACES}" http://localhost:${PORT}/upload/${BUNDLE_NAME} >/dev/null || fail "Failed to upload files"
+log_debug "Uploaded 1 file with spaces"
+
+curl -s  "http://localhost:${PORT}/bundle/${BUNDLE_NAME}/${F1_WITH_SPACES}" > ${TEMPDIR}/${F1} || fail "Failed to download file"
+log_debug "Downloaded 1 file (saved without spaces)"
+
+kill ${WEB_PID}
+wait ${WEB_PID} || echo "Web shut down"
+
+check_files ${NASEFA_ROOT} ${TEMPDIR} ${F1}