Allow checking a binary filter without deserializing to a resource #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
at first glance it looks like the resource usage of contain wouldn't work, but I could just be mistaken. I will take another look later in the week and give it a run. This addition is much appreciated. |
|
It checks if its a resource, if it's not a resource it checks if its a binary and tries to populate the xor filter struct/fingerprints from the values in the binary. This definitely does work as I've done quite a lot of benchmarking with it. |
|
My mistake, my cursory glace was wrong! |
|
Any updates on this? |
|
My mistake, have been distracted recently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.