Added showMessageWithColorDuration #2
Conversation
Added showMessageWithColorDuration to allow custom background color and duration of the message
|
Hi, thanks for the PR! Can you please extend the example app.js and more importantly the README? |
|
Hi Marcel, sure I will do that. After I did the pull request I thought hmmm I should add an example of the new method. I will probably change something else in the code too. The 'show' method seems to always use a hard-coded white background instead of transparent. Meaning that it hides the status bar (clock and such), only the battery indicator is shown. Using the showSuccessMessage and showErrorMessage and the added showMessageWithColorDuration are showing the contents of the status bar. |
|
Hi, that's a good idea. If you want you can also take a look at the original module and make a pull request with your additions there. https://github.com/mwkoelb/MWKProgressIndicator |
|
good idea, I already used the PR that is pending there to improve the orientation issue. mwkoelb/MWKProgressIndicator#3 |
Added showMessageWithColor to show a message with a custom color. Also update the README.md and example app.js showing how to use the new methods
|
New commit with updated README and example app |
Added showMessageWithColorDuration
Added showMessageWithColorDuration to allow custom background color and
duration of the message