fix :ssl-options handling

[blak3mill3r]

prior to this commit it didn't work at all
instance? args were reversed
Builder instance was returned rather than SSLOptions

now it works (tested with a jks keystore)

[mpenet]

Good catch, thanks. I ll merge and release shortly after.

[mpenet]

It's now available as 3.1.4 (alia or alia-all).

Cheers

[blak3mill3r]

That was quick work. Thanks!

On Tue, Apr 12, 2016 at 9:07 AM, Max Penet notifications@github.com wrote:

It's now available as 3.1.4 (alia or alia-all).

Cheers

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#55 (comment)

[mpenet]

You're welcome. Quick feedback on issues/PRs is very important imho, I tried to respond asap.

One little tip (you might have figured it out already), alia options are extensible at runtime: when things are broken like this you can always define your own defmethod of alia/cluster-options/set-cluster-option that fixes the bug then use it via cluster options transparently. This way you can overwrite broken stuff or make new ones that do you own recipes before the cluster builder is, well, built :>

for reference: https://github.com/mpenet/alia/blob/master/modules/alia/src/qbits/alia/cluster_options.clj#L294
https://github.com/mpenet/alia/blob/master/modules/alia/src/qbits/alia/cluster_options.clj#L289

[blak3mill3r]

Good to know, and a great design principle. Thanks.

Quick PR responses certainly encourage me to contribute fixes. :)

On Tue, Apr 12, 2016 at 9:16 AM, Max Penet notifications@github.com wrote:

You're welcome. Quick feedback on issues/PRs is very important imho, I
tried to respond asap.

One little tip (you might have figured it out already), alia options are
extensible at runtime: when things are broken like this you can always
define your own defmethod of alia/set-cluster-option that fixes the bug
then use it via cluster options transparently. This way you can overwrite
broken stuff or make new ones that do you own recipes before the cluster
builder is, well, built :>

for reference:
https://github.com/mpenet/alia/blob/master/modules/alia/src/qbits/alia/cluster_options.clj#L294

https://github.com/mpenet/alia/blob/master/modules/alia/src/qbits/alia/cluster_options.clj#L289

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#55 (comment)