Skip to content

Commit

Permalink
Fix Psalm complaints after merge-up
Browse files Browse the repository at this point in the history
  • Loading branch information
mpdude committed Feb 1, 2024
1 parent 1df03f2 commit c7a91a4
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 8 deletions.
3 changes: 0 additions & 3 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -890,9 +890,6 @@
<PossiblyInvalidIterator>
<code><![CDATA[$this->sqlStatements]]></code>
</PossiblyInvalidIterator>
<PropertyNotSetInConstructor>
<code>MultiTableUpdateExecutor</code>
</PropertyNotSetInConstructor>
</file>
<file src="src/Query/Exec/SingleSelectExecutor.php">
<PossiblyInvalidArgument>
Expand Down
1 change: 0 additions & 1 deletion psalm.xml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,6 @@
<errorLevel type="suppress">
<!-- https://github.com/vimeo/psalm/issues/8819 -->
<file name="src/Internal/Hydration/AbstractHydrator.php"/>
<referencedClass name="Doctrine\DBAL\Platforms\MySQLPlatform" />
</errorLevel>
</InvalidReturnType>
<InvalidParamDefault>
Expand Down
9 changes: 5 additions & 4 deletions src/Query/Exec/MultiTableUpdateExecutor.php
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,11 @@ class MultiTableUpdateExecutor extends AbstractSqlExecutor
*/
public function __construct(AST\Node $AST, SqlWalker $sqlWalker)
{
$em = $sqlWalker->getEntityManager();
$conn = $em->getConnection();
$platform = $conn->getDatabasePlatform();
$quoteStrategy = $em->getConfiguration()->getQuoteStrategy();
$em = $sqlWalker->getEntityManager();
$conn = $em->getConnection();
$platform = $conn->getDatabasePlatform();
$quoteStrategy = $em->getConfiguration()->getQuoteStrategy();
$this->sqlStatements = [];

if ($conn instanceof PrimaryReadReplicaConnection) {
$conn->ensureConnectedToPrimary();
Expand Down

0 comments on commit c7a91a4

Please sign in to comment.