Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update Appsflyer SPM dependency to new repo #45

Merged
merged 3 commits into from
Apr 1, 2024
Merged

fix: Update Appsflyer SPM dependency to new repo #45

merged 3 commits into from
Apr 1, 2024

Conversation

einsteinx2
Copy link
Contributor

Summary

  • Points to fixed AppsFlyer SPM repo (still uses static version like we've always done)
  • Added Privacy Manifest
  • Fixed the unit test target and 2 failing tests

Testing Plan

  • Was this tested locally? If not, explain why.
  • Added to a test apps using both SPM and Cocoapods and ran unit tests

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

BrandonStalnaker
BrandonStalnaker approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@BrandonStalnaker BrandonStalnaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for adding the privacy manifest.

@einsteinx2 einsteinx2 merged commit a6995a7 into development Apr 1, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrandonStalnaker BrandonStalnaker BrandonStalnaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@einsteinx2 @BrandonStalnaker