This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
Polishing of SonarLint issues #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
local var channel hides field channel Replace StringBuffer with StringBuilder because of local usage (no sync needed) Add private constructors to non instance classes
mp911de
suggested changes
Jan 10, 2020
There was a problem hiding this comment.
Thanks a lot. Most changes are fine that also fix some stylistic inconsistencies in our code. The change regarding potential hidden instance fields, I'm reluctant. Adding a my… prefix rather increases the mental effort to gist the code while reading it. Care to have a look?
src/main/java/biz/paluch/logging/gelf/GelfMessageAssembler.java
Outdated
Show resolved
Hide resolved
|
Reverted the unshadowing of fields and the map field name. |
|
Thanks a lot, that's merged now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure that:
This reduces the number of sonarlint issues in the main code to 91.