Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Polishing of SonarLint issues #220

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Polishing of SonarLint issues #220

merged 1 commit into from
Jan 10, 2020

Conversation

sfuhrm
Copy link
Contributor

@sfuhrm sfuhrm commented Jan 4, 2020 •
edited
Loading

Make sure that:

  • You have read the contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

This PR reduces the SonarLint issues from 172 to 162.

@sfuhrm sfuhrm changed the title Sonarlint 172 to 161 Sonarlint 172 to 162 Jan 4, 2020
@mp911de
Copy link
Owner

mp911de commented Jan 7, 2020

Thanks for the changes. Care to squash your changes into a single commit?

@mp911de mp911de added the type: task A general task label Jan 7, 2020
@mp911de mp911de added this to the 1.14.0 milestone Jan 7, 2020
@sfuhrm
SonarLint fixes:
a05b86d 
local var channel hides field channel
Replace StringBuffer with StringBuilder because of local usage (no sync needed)
Add private constructors to non instance classes
@sfuhrm
Copy link
Contributor Author

sfuhrm commented Jan 7, 2020

@mp911de squashed and ready :)

@mp911de mp911de merged commit e5cc39c into mp911de:master Jan 10, 2020
@mp911de
Copy link
Owner

mp911de commented Jan 10, 2020

Thank you for your contribution. That's merged now.

@sfuhrm sfuhrm deleted the SONARLINT branch January 11, 2020 15:20
@sfuhrm sfuhrm restored the SONARLINT branch January 11, 2020 15:20
@mp911de mp911de changed the title Sonarlint 172 to 162 Polishing of SonarLint issues Jan 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sfuhrm @mp911de