Skip to content

Commit

Permalink
Put ${INPUT_RUBOCOP_FLAGS} at the end of the other flags
Browse files Browse the repository at this point in the history
Since PR reviewdog#103 introduced the default --fail-level flag,
the severity level has become unchangeable due to this
modification.
Ideally, this flag (and others) should be overridable,
but the RuboCop command prioritizes the flags that are
specified last. This commit moves the user-specified
flags to the end of the hard-coded flags, allowing them
to be overridden.

Signed-off-by: moznion <moznion@mail.moznion.net>
  • Loading branch information
moznion committed Aug 21, 2024
1 parent 5755da6 commit 4c2253a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion script.sh
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,10 @@ fi
echo '::group:: Running rubocop with reviewdog 🐶 ...'
# shellcheck disable=SC2086
${BUNDLE_EXEC}rubocop \
${INPUT_RUBOCOP_FLAGS} \
--require ${GITHUB_ACTION_PATH}/rdjson_formatter/rdjson_formatter.rb \
--format RdjsonFormatter \
--fail-level error \
${INPUT_RUBOCOP_FLAGS} \
"${CHANGED_FILES[@]}" \
| reviewdog -f=rdjson \
-name="${INPUT_TOOL_NAME}" \
Expand Down

0 comments on commit 4c2253a

Please sign in to comment.