Add optional check for experiment cookie to persist previously seen variations (Fixes #93) #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgibson
force-pushed
the
variation-cookie
branch
from
1108aad to
aabcc0a
Compare
alexgibson
force-pushed
the
variation-cookie
branch
from
aabcc0a to
4651185
Compare
alexgibson
force-pushed
the
variation-cookie
branch
2 times, most recently
from
6a93aa6 to
95cd170
Compare
alexgibson
force-pushed
the
variation-cookie
branch
from
95cd170 to
d647374
Compare
alexgibson
force-pushed
the
variation-cookie
branch
from
d647374 to
be54f7b
Compare
|
I'm not sure what I'm doing wrong but I'm not able to run the demo locally because it can't find the cookie library:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst traffic cop no longer sets cookies itself, there are circumstances where we might want to ensure a variation is seen again on repeat page visits once a visitor is entered into an experiment (such as a full page redesign).
This PR adds an optional check to read an experiment cookie that can be set by the initiating website. This enables websites to be responsible for handing cookie consent, and provided cookies are accepted, Traffic Cop can then more consistently show the same variation on repeat visits.
Testing:
npm install && npm run buildcd demo && npm install && npm start