Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: chromedriver and geckodriver dependencies along with circleci config #584

Merged
merged 4 commits into from
Apr 11, 2024

Conversation

rpl
Copy link
Member

@rpl rpl commented Apr 11, 2024

This PR includes a set of changes needed to fix the CI job failures currently hit due to mismatch between the Chrome version installed in the CI jobs and the Chrome versions supported by the chromedriver dev dependencies (and so it supersedes also PR #573).

Along with that change this PR is also:

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.71%. Comparing base (ff464da) to head (976330a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   90.71%   90.71%           
=======================================
  Files           1        1           
  Lines         140      140           
=======================================
  Hits          127      127           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpl rpl merged commit 338d75f into master Apr 11, 2024
3 checks passed
@rpl rpl deleted the chore/update-circleci-chromedriver-geckodriver branch April 11, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants