Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint: Enforce quotes #355

Merged
merged 1 commit into from
Jan 18, 2022
Merged

Lint: Enforce quotes #355

merged 1 commit into from
Jan 18, 2022

Conversation

fregante
Copy link
Contributor

If there's a lint, follow it and enforce it, otherwise it just adds noise.

Before

❯ grunt eslint
Running "eslint:src" (eslint) task


Running "eslint:test" (eslint) task

./test/fixtures/detect-existing-browser-api-object/content.js
  40:42  warning  Strings must use doublequote  quotes
  41:14  warning  Strings must use doublequote  quotes
  43:30  warning  Strings must use doublequote  quotes
  48:36  warning  Strings must use doublequote  quotes
  50:36  warning  Strings must use doublequote  quotes
  51:47  warning  Strings must use doublequote  quotes

✖ 6 problems (0 errors, 6 warnings)
  0 errors and 6 warnings potentially fixable with the `--fix` option.


Done.

After

grunt eslint
Running "eslint:src" (eslint) task


Running "eslint:test" (eslint) task


Done.

@codecov
Copy link

codecov bot commented Nov 27, 2021

Codecov Report

Merging #355 (9dcbf2f) into master (2d75968) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #355   +/-   ##
=======================================
  Coverage   91.03%   91.03%           
=======================================
  Files           1        1           
  Lines         145      145           
=======================================
  Hits          132      132           
  Misses         13       13           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d75968...9dcbf2f. Read the comment docs.

Copy link
Member

@Rob--W Rob--W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@fregante
Copy link
Contributor Author

Should this be merged before any conflicts arise?

@rpl rpl merged commit 31ed31a into mozilla:master Jan 18, 2022
@fregante fregante deleted the just-lint-it branch January 19, 2022 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants