-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting lint errors with manifest_version set to 3 #2484
Comments
Duplicate of #2379. In short, use the |
Actually, the other one is about running, while this one is about the linter. |
@Rob--W Can we reopen this please? |
I have already re-opened this issue :) |
not only linting, I'm unable to run my extension with firefox. |
test.log |
@akash07k What version of Firefox are you using? |
Hit the linting issue as well -
|
Yep
…On 8/21/2022 2:15 AM, James Robert Somers wrote:
Hit the linting issue as well - |--firefox-preview| only seems to be
applicable to |web-ext run| so far, but it's making it difficult to
maintain an extension across Firefox and Chrome.
|$ node_modules/.bin/web-ext --version 7.2.0 $
node_modules/.bin/web-ext lint -s src Applying config file:
./package.json Validation Summary: errors 2 notices 0 warnings 0
ERRORS: Code Message Description File Line Column JSON_INVALID
"/manifest_version" must be <= 2 Your JSON file could not be parsed.
EXTENSION_ID_REQUIRED The extension ID is required in Manifest See
https://mzl.la/3PLZYdo for more information. manifest.json Version 3
and above. $ node_modules/.bin/web-ext lint --firefox-preview -s src
web-ext lint Validate the extension source <snip options dump> Unknown
arguments: firefox-preview, firefoxPreview |
—
Reply to this email directly, view it on GitHub
<#2484 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQWBM63D2R5FOV3MS3EX6DV2E7XFANCNFSM56WRI6FA>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks :-)
…On 8/17/2022 1:08 AM, Rob Wu wrote:
I have already re-opened this issue :)
—
Reply to this email directly, view it on GitHub
<#2484 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABQWBM66NRO55FIKKQ5X25DVZPU2BANCNFSM56WRI6FA>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Is this a feature request or a bug?
Bug
What is the current behavior?
Getting error while linting if the manifest_version is set to 3:
"manifest_version": 3
,Error:
What is the expected or desired behavior?
Lint command should not throw error
log.txt
Version information (for bug reports)
Node V18.7.0
NPM V 8.15.0
web-ext V7.2.0
The text was updated successfully, but these errors were encountered: