Fix Python error name regression #2240
Merged
+77
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendk
commented
Sep 19, 2024
| visitor.visit_error_name(&mut name); | ||
| name | ||
| }) | ||
| .collect() |
There was a problem hiding this comment.
This is one issue, this is a somewhat hacky field that stores error type names when we see them in "[Throws=]" UDL attributes. I think that proc-macros might have handled this correctly, but I'm not sure.
There was a problem hiding this comment.
I like drain in combination with collect. I think I could have used something similar here as well!
5 tasks
bendk
force-pushed
the
push-nlslvovtvqxq
branch
from
c682669
to
6cd8464
Compare
bendk
commented
Sep 19, 2024
| @@ -22,7 +22,7 @@ impl CodeType for ErrorCodeType { | |||
| } | |||
|
|
|||
| fn canonical_name(&self) -> String { | |||
| format!("Type{}", self.id) | |||
| format!("Type{}", self.type_label()) | |||
There was a problem hiding this comment.
This is the other issue. There were 2 paths for calculating FFI converters and they didn't use the same logic:
- The ffi_converter_name filter called CodeType::ffi_converter_name, which called
canonical_nameand that usedid, which is the original name. - But the generated class uses a different ffi_converter_name which had the converted name.
There was a problem hiding this comment.
Maybe I only needed to modify ErrorCodeType::canonical_name, but it seemed safer to change all of the class-like types to use the converted name.
bendk
force-pushed
the
push-nlslvovtvqxq
branch
from
6cd8464
to
811976c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit this one when trying to upgrade application-services to 0.28.1. It's kind of surprising that this is the first we're hearing of it, but I guess the Python bindings users are a minority.