-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented buildMap todo for kotlin #1717
Conversation
return buildMap<{{ key_type_name }}, {{ value_type_name }}> { | ||
val len = buf.getInt() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a buildMap
variant that takes a capacity
parameter and should be more performant, maybe the len
value could be used for that?
val len = buf.getInt()
return buildMap<{{ key_type_name }}, {{ value_type_name }}>(len) {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, didn't notice that. Fixed.
build failing because of rust dependencies
|
If you rebase on |
514a3f8
to
331098f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is passing, let's take this.
there was todo to use buildMap, it is stable since Kotlin 1.6
implemented todo
note - I was not able to run tests from doker image with
But I hope they will run in PR flow now.