-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1866550 - Ingest replicates for speedometer3 on mozilla-central. #7886
Conversation
Locally, I tested this by ingesting this push: https://treeherder.mozilla.org/jobs?repo=mozilla-central&tier=1%2C2%2C3&searchStr=browsertime%2Cspeedometer3&revision=29d489a7e05adef3300e076dd1c46d14928ddf24 After that, I ran the following query on my local DB to confirm that only speedometer3 has been ingested. It should return nothing because it's looking for any suite that isn't
If you change |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #7886 +/- ##
==========================================
- Coverage 76.93% 76.93% -0.01%
==========================================
Files 541 541
Lines 26763 26765 +2
Branches 3360 3360
==========================================
+ Hits 20591 20592 +1
- Misses 6007 6008 +1
Partials 165 165 ☔ View full report in Codecov by Sentry. |
treeherder/etl/perf.py
Outdated
if ( | ||
replicates | ||
and len(replicates) > 0 | ||
and suite_name == "speedometer3" | ||
and repository.name in ("mozilla-central",) | ||
): | ||
return True | ||
return replicates and len(replicates) > 0 and repository.name in ("try",) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Nit: Just a bit of duplication with this check replicates and len(replicates) > 0
Seems to have failed on an unrelated test in my last push so I've pushed a couple of test commits to see if it resolves itself:
|
This patch adds a button to enable using replicates in the graphs view. The button is made available all the time as the cases for where replicates are available are not limited to a single branch anymore after PR #7886 lands. It also changes the API to return replicates for the specific case that the graphs view querys for (all_data).
This patch enables replicate ingestion into the
performance_datum_replicate
table on mozilla-central for only speedometer3 tests.