Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1866550 - Ingest replicates for speedometer3 on mozilla-central. #7886

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

gmierz
Copy link
Collaborator

@gmierz gmierz commented Nov 24, 2023

This patch enables replicate ingestion into the performance_datum_replicate table on mozilla-central for only speedometer3 tests.

@gmierz
Copy link
Collaborator Author

gmierz commented Nov 24, 2023

Locally, I tested this by ingesting this push: https://treeherder.mozilla.org/jobs?repo=mozilla-central&tier=1%2C2%2C3&searchStr=browsertime%2Cspeedometer3&revision=29d489a7e05adef3300e076dd1c46d14928ddf24

After that, I ran the following query on my local DB to confirm that only speedometer3 has been ingested. It should return nothing because it's looking for any suite that isn't speedometer3:

select performance_signature.suite, performance_signature.application from performance_datum
inner join performance_datum_replicate on performance_datum_replicate.performance_datum_id = performance_datum.id
inner join performance_signature on performance_signature.id = performance_datum.signature_id
where performance_signature.suite not like "%speedometer3%"

If you change not like to like you should see the speedometer3 replicates, and the application they're coming from.

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (45d0c67) 76.93% compared to head (65f2dae) 76.93%.

Files Patch % Lines
treeherder/etl/perf.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7886      +/-   ##
==========================================
- Coverage   76.93%   76.93%   -0.01%     
==========================================
  Files         541      541              
  Lines       26763    26765       +2     
  Branches     3360     3360              
==========================================
+ Hits        20591    20592       +1     
- Misses       6007     6008       +1     
  Partials      165      165              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines 131 to 138
if (
replicates
and len(replicates) > 0
and suite_name == "speedometer3"
and repository.name in ("mozilla-central",)
):
return True
return replicates and len(replicates) > 0 and repository.name in ("try",)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
Nit: Just a bit of duplication with this check replicates and len(replicates) > 0

@gmierz
Copy link
Collaborator Author

gmierz commented Nov 28, 2023

Seems to have failed on an unrelated test in my last push so I've pushed a couple of test commits to see if it resolves itself:

E       AssertionError: assert [{'created': ...HcXLs'}, ...}] == [{'created': ...HcXLs'}, ...}]
E         At index 0 diff: {'id': 2, 'job': {'task_id': 'V3SVuxO8TFy37En_6HcXLs', 'job_type_name': 'B2G Emulator Image Build', 'result': 'success', 'duration': 191}, 'failure_classification_name': 'expected fail', 'created': '2023-11-27T18:13:30.788133', 'who': 'user@foo.com', 'text': 'you look like a man-o-lantern'} != {'id': 1, 'job': {'task_id': 'V3SVuxO8TFy37En_6HcXLs', 'job_type_name': 'B2G Emulator Image Build', 'result': 'success', 'duration': 191}, 'failure_classification_name': 'fixed by commit', 'who': 'user@foo.com', 'created': '2023-11-27T18:13:30.782394', 'text': 'you look like a man-o-lantern'}
E         Use -v to get more diff

tests/webapp/api/test_note_api.py:157: AssertionError

@gmierz gmierz merged commit 0060933 into mozilla:master Nov 28, 2023
gmierz added a commit that referenced this pull request Dec 12, 2023
This patch adds a button to enable using replicates in the graphs view. The button is made available all the time as the cases for where replicates are available are not limited to a single branch anymore after PR #7886 lands. It also changes the API to return replicates for the specific case that the graphs view querys for (all_data).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants